linux-kernel - RE: [PATCH v4 2/2] exfat: add support ioctl and FITRIM function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04aa01d70f31$6de160a0$49a421e0$@samsung.com>
Date:   Tue, 2 Mar 2021 15:58:20 +0900
From:   "Sungjong Seo" <sj1557.seo@...sung.com>
To:     "'Hyeongseok Kim'" <hyeongseok@...il.com>,
        <namjae.jeon@...sung.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        "'Chaitanya Kulkarni'" <chaitanya.kulkarni@....com>,
        <sj1557.seo@...sung.com>
Subject: RE: [PATCH v4 2/2] exfat: add support ioctl and FITRIM function

> Add FITRIM ioctl to enable discarding unused blocks while mounted.
> As current exFAT doesn't have generic ioctl handler, add empty ioctl
> function first, and add FITRIM handler.
> 
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>
> Signed-off-by: Hyeongseok Kim <hyeongseok@...il.com>
> ---
>  fs/exfat/balloc.c   | 80 +++++++++++++++++++++++++++++++++++++++++++++
>  fs/exfat/dir.c      |  5 +++
>  fs/exfat/exfat_fs.h |  4 +++
>  fs/exfat/file.c     | 53 ++++++++++++++++++++++++++++++
>  4 files changed, 142 insertions(+)
> 

It looks better than v3.
Thanks for your work!

Acked-by: Sungjong Seo <sj1557.seo@...sung.com>

BTW, there is still a problem that the alloc/free cluster operation waits
until the trimfs operation is finished.
Any ideas for improvement in the future are welcome. :)