linux-kernel - RE: [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Mar 2021 13:15:15 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Bean Huo <huobean@...il.com>,
        "daejun7.park@...sung.com" <daejun7.park@...sung.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: RE: [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support

> 
> 
> On Fri, 2021-02-26 at 16:35 +0900, Daejun Park wrote:
> > +static void ufshpb_set_unmap_cmd(unsigned char *cdb, struct
> > ufshpb_region *rgn)
> > +{
> > +       cdb[0] = UFSHPB_WRITE_BUFFER;
> > +       cdb[1] = rgn ? UFSHPB_WRITE_BUFFER_INACT_SINGLE_ID :
> > +                         UFSHPB_WRITE_BUFFER_INACT_ALL_ID;
> 
> Here is wrong,
> Valid HPB Region is (0 ~ (Ceiling( Region size calculated by
> bHPBRegionSize )- 1) ). how do you know the region==0 is not
> a single normal region?
Please note that rgn  here is a ufshpb_region *rgn

Thanks,
Avri

> 
> Bean
> 
> 
> > +       if (rgn)
> > +               put_unaligned_be16(rgn->rgn_idx, &cdb[2]);
> > +       cdb[9] = 0x00;
> > +}
> 
>