linux-kernel - Re: [PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58e8dcea7f3567001c807ca9399f191a4bcaea40.camel@gmail.com>
Date:   Tue, 02 Mar 2021 14:04:38 +0100
From:   Bean Huo <huobean@...il.com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        Avri Altman <Avri.Altman@....com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Can Guo <cang@...eaurora.org>,
        Asutosh Das <asutoshd@...eaurora.org>,
        Stanley Chu <stanley.chu@...iatek.com>
Subject: Re: [PATCH] scsi: ufs: Fix incorrect ufshcd_state after
 ufshcd_reset_and_restore()

On Tue, 2021-03-02 at 10:14 +0200, Adrian Hunter wrote:
> > > That can result in the state being UFSHCD_STATE_ERROR even though
> > > ufshcd_reset_and_restore() is successful and returns zero.
> > > 
> > > Fix by initializing the state to UFSHCD_STATE_RESET in the start
> > > of each
> > > loop in ufshcd_reset_and_restore().  If there is an error,
> > > ufshcd_reset_and_restore() will change the state to
> > > UFSHCD_STATE_ERROR,
> > > otherwise ufshcd_probe_hba() will have set the state
> > > appropriately.
> > > 
> > > Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler
> > > and other
> > > error recovery paths")
> > > Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> > 
> > I think that CanG recent series addressed that issue as well, can
> > you take a look?
> > 
https://lore.kernel.org/lkml/1614145010-36079-2-git-send-email-cang@codeaurora.org/
> 
> Yes, there it is mixed in with other changes.  However it is probably
> better
> as a separate patch.  Can Guo, what do you think?

we can firstly take this fixup patch.