linux-kernel - Re: [RFC PATCH v2 00/13] objtool: add base support for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210304140308.1891245-1-jthierry@redhat.com>
Date:   Thu,  4 Mar 2021 15:03:08 +0100
From:   Julien Thierry <jthierry@...hat.com>
To:     peterz@...radead.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        catalin.marinas@....com, will@...nel.org, mark.rutland@....com,
        ardb@...nel.org, masahiroy@...nel.org, jpoimboe@...hat.com,
        ycote@...hat.com, Julien Thierry <jthierry@...hat.com>
Subject: Re: [RFC PATCH v2 00/13] objtool: add base support for arm64

On 3/3/21 8:17 PM, Peter Zijlstra wrote:
> One selfish thing, would it make sense to have a make target that builds
> all supported srcarch targets?
>
> This might be useful when hacking on objtool to make sure everything
> builds.
>

That makes sense. I can offer something like bellow which is simple
enough to use and update.

Otherwise you could have per arch targets, but since the generic part of
objtool uses arch specific headers, you'll have to rebuild object files
between two arch builds anyway.

Julien

-->

>From 36cf9e05f2ee40bd5239c3b78cd1c5260941cb94 Mon Sep 17 00:00:00 2001
Date: Thu, 4 Mar 2021 14:46:39 +0100
Subject: [PATCH] objtool: Add target to test build of different architectures

To make sure support for other architecture doesn't break when updating
objtool, it's useful to have a shorthand to build the different objtool
configuration.

Add a target that can be called from the top level as such:

    $ make tools/objtool/build-test

Signed-off-by: Julien Thierry <jthierry@...hat.com>
---
 tools/Makefile         | 3 +++
 tools/objtool/Makefile | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/tools/Makefile b/tools/Makefile
index 7e9d34ddd74c..79e4a5ff0576 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -68,6 +68,9 @@ cpupower: FORCE
 cgroup firewire hv guest bootconfig spi usb virtio vm bpf iio gpio objtool leds wmi pci firmware debugging tracing: FORCE
 	$(call descend,$@)

+objtool/%: FORCE
+	$(call descend,objtool,$@)
+
 bpf/%: FORCE
 	$(call descend,$@)

diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index d5cfbec87c02..4c57f8cdaeb6 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -56,6 +56,12 @@ export SUBCMD_CHECK SUBCMD_ORC
 export srctree OUTPUT CFLAGS SRCARCH AWK
 include $(srctree)/tools/build/Makefile.include

+objtool/build-test: FORCE
+	@SRCARCH=x86 $(MAKE)
+	@SRCARCH=x86 $(MAKE) clean
+	@SRCARCH=arm64 $(MAKE)
+	@SRCARCH=arm64 $(MAKE) clean
+
 $(OBJTOOL_IN): fixdep FORCE
 	@$(CONFIG_SHELL) ./sync-check.sh
 	@$(MAKE) $(build)=objtool
--
2.25.4