linux-kernel - Re: [PATCH] powerpc: remove redundant space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210303223358.Horde.OAg4JN_IZgwz7hkYuMwiTg3@messagerie.c-s.fr>
Date:   Wed, 03 Mar 2021 22:33:58 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     maqiang <maqianga@...ontech.com>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        paulus@...ba.org, benh@...nel.crashing.org, mpe@...erman.id.au
Subject: Re: [PATCH] powerpc: remove redundant space

maqiang <maqianga@...ontech.com> a écrit :

> These one line of code don't meet the kernel coding style,
> so remove the redundant space.

There seems to be several other style issues in this function and in  
the following one too. You should fix them all at once I think.


>
> Signed-off-by: maqiang <maqianga@...ontech.com>
> ---
>  arch/powerpc/kernel/syscalls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
> index 078608ec2e92..9248288752d5 100644
> --- a/arch/powerpc/kernel/syscalls.c
> +++ b/arch/powerpc/kernel/syscalls.c
> @@ -81,7 +81,7 @@ SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
>  int
>  ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set  
> __user *exp, struct __kernel_old_timeval __user *tvp)
>  {
> -	if ( (unsigned long)n >= 4096 )
> +	if ((unsigned long)n >= 4096)
>  	{
>  		unsigned long __user *buffer = (unsigned long __user *)n;
>  		if (!access_ok(buffer, 5*sizeof(unsigned long))
> --
> 2.20.1