linux-kernel - Re: [PATCH] remoteproc: sysfs: Use scnprintf instead of sprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8132211-09b1-52c5-61a0-7f8ac058ed96@codeaurora.org>
Date:   Wed, 3 Mar 2021 13:38:30 -0800
From:   Siddharth Gupta <sidgup@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     ohad@...ery.com, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Raghavendra Rao Ananta <rananta@...eaurora.org>
Subject: Re: [PATCH] remoteproc: sysfs: Use scnprintf instead of sprintf


On 3/3/2021 12:56 PM, Bjorn Andersson wrote:
> On Wed 03 Mar 14:01 CST 2021, Siddharth Gupta wrote:
>
>> From: Raghavendra Rao Ananta <rananta@...eaurora.org>
>>
>> For security reasons scnprintf() is preferred over sprintf().
>> Hence, convert the remoteproc's sysfs show functions accordingly.
>>
> Thanks for the patch Siddharth.
>
> There's no possibility for these calls to generate more than PAGE_SIZE
> amount of data, so this isn't really necessary. But if you insist,
> please let's use sysfs_emit() instead.
>
> Regards,
> Bjorn
Sure Bjorn, I'll push the new patch immediately.

Thanks,
Siddharth
>
>> Signed-off-by: Raghavendra Rao Ananta <rananta@...eaurora.org>
>> Signed-off-by: Siddharth Gupta <sidgup@...eaurora.org>
>> ---
>>   drivers/remoteproc/remoteproc_sysfs.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c
>> index 1dbef89..853f569 100644
>> --- a/drivers/remoteproc/remoteproc_sysfs.c
>> +++ b/drivers/remoteproc/remoteproc_sysfs.c
>> @@ -15,7 +15,8 @@ static ssize_t recovery_show(struct device *dev,
>>   {
>>   	struct rproc *rproc = to_rproc(dev);
>>   
>> -	return sprintf(buf, "%s", rproc->recovery_disabled ? "disabled\n" : "enabled\n");
>> +	return scnprintf(buf, PAGE_SIZE, "%s",
>> +			 rproc->recovery_disabled ? "disabled\n" : "enabled\n");
>>   }
>>   
>>   /*
>> @@ -82,7 +83,7 @@ static ssize_t coredump_show(struct device *dev,
>>   {
>>   	struct rproc *rproc = to_rproc(dev);
>>   
>> -	return sprintf(buf, "%s\n", rproc_coredump_str[rproc->dump_conf]);
>> +	return scnprintf(buf, PAGE_SIZE, "%s\n", rproc_coredump_str[rproc->dump_conf]);
>>   }
>>   
>>   /*
>> -- 
>> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>