linux-kernel - Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74955041-45ab-10df-e044-5d64898c81d9@huawei.com>
Date:   Thu, 4 Mar 2021 09:34:44 +0000
From:   John Garry <john.garry@...wei.com>
To:     Shunsuke Nakamura <nakamura.shun@...itsu.com>, <will@...nel.org>,
        <mathieu.poirier@...aro.org>, <leo.yan@...aro.org>,
        <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...hat.com>, <namhyung@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name

On 04/03/2021 03:26, Shunsuke Nakamura wrote:
> From: Shunsuke Nakamura <nakamura.shun@...fujitsu.com>
> 
> Add the lexical definition of event name so that the numbers are recognizable.
> 

Sorry for the hassle, but it's not clear that we got a definitive 
conclusion on this patch from v6 series:

https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/

Would it be so much worse for you to change format of these event names 
to not start with a numberic?

Thanks



> A64FX defines an event name that starts with a number.
>   - 0inst_commit
>   - 1inst_commit
>   - 2inst_commit
>   - 3inst_commit
>   - 4inst_commit
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@...itsu.com>
> Acked-by: John Garry <john.garry@...wei.com>
> ---
>   tools/perf/util/parse-events.l | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 0b36285a9435..33f627187415 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -205,7 +205,7 @@ bpf_source	[^,{}]+\.c[a-zA-Z0-9._]*
>   num_dec		[0-9]+
>   num_hex		0x[a-fA-F0-9]+
>   num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]*
> +name		[a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]*
>   name_tag	[\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\']
>   name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.:]*
>   drv_cfg_term	[a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
>