linux-kernel - Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d45ac1495eea68aca7d2b85063c2559@walle.cc>
Date:   Thu, 04 Mar 2021 12:59:09 +0100
From:   Michael Walle <michael@...le.cc>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Li Yang <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event
 Collector

Am 2021-03-04 12:37, schrieb Shawn Guo:
> On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
>> The legacy interrupt INT_A is hardwired to the event collector. RCEC 
>> is
>> bascially supported starting with v5.11. Having a correct interrupt, 
>> will
>> make RCEC at least probe correctly.
>> 
>> There are still issues with how RCEC is implemented in the RCiEP on 
>> the
>> LS1028A. RCEC will report an error, but it cannot find the correct
>> subdevice.
>> 
>> Signed-off-by: Michael Walle <michael@...le.cc>
>> ---
>>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi 
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 262fbad8f0ec..c1f2f402ad53 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -1114,6 +1114,12 @@
>>  					full-duplex;
>>  				};
>>  			};
>> +
>> +			rcec@1f,0 {
> 
> Just curious how unit-address comes to '1f,0'?

You mean that it's pci dev 1f func 0?
0x00f800 >> 11 == 0x1f

See also:
https://elixir.bootlin.com/linux/v5.12-rc1/source/scripts/dtc/checks.c#L916

-michael

> 
> Shawn
> 
>> +				reg = <0x00f800 0 0 0 0>;
>> +				/* IEP INT_A */
>> +				interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>> +			};
>>  		};
>> 
>>  		rcpm: power-controller@...4040 {
>> --
>> 2.20.1
>>