linux-kernel - Re: [PATCH] tracing/tools: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210305092136.7f6a33d1@gandalf.local.home>
Date:   Fri, 5 Mar 2021 09:21:36 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     <Viktor.Rosendahl@....de>
Cc:     <vulab@...as.ac.cn>, <linux-kernel@...r.kernel.org>,
        <colin.king@...onical.com>
Subject: Re: [PATCH] tracing/tools: Remove unneeded semicolon

On Fri, 5 Mar 2021 10:42:08 +0000
<Viktor.Rosendahl@....de> wrote:

> Looks good but I would suggest to fix also the other instances of superfluous
> semicolons with the same patch.
> 
> There seems to be a lonely semicolon on line 1944, i.e this code:
> 
> 			if (value < 0) {
> 				warnx("TIME must be >= 0\n");
> 				show_usage();
> 				;
> 			}
> 
> In that case the lonely semicolon should be replaced with "exit(0);"

Agreed. I'll wait for v2 of the patch.

Thanks,

-- Steve