linux-kernel - Re: [PATCH] tracing/tools: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <480322830b8aa400f4293e635184a31d392e4dad.camel@bmw.de>
Date:   Fri, 5 Mar 2021 10:42:08 +0000
From:   <Viktor.Rosendahl@....de>
To:     <vulab@...as.ac.cn>
CC:     <rostedt@...dmis.org>, <linux-kernel@...r.kernel.org>,
        <colin.king@...onical.com>
Subject: Re: [PATCH] tracing/tools: Remove unneeded semicolon

On Fri, 2021-03-05 at 09:40 +0000, Xu Wang wrote:
> fix semicolon.cocci warning:
> tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  tools/tracing/latency/latency-collector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/tracing/latency/latency-collector.c
> b/tools/tracing/latency/latency-collector.c
> index b69de9263ee6..129fb00b70c2 100644
> --- a/tools/tracing/latency/latency-collector.c
> +++ b/tools/tracing/latency/latency-collector.c
> @@ -1018,7 +1018,7 @@ static long go_to_sleep(const struct entry *req)
>  		cond_timedwait(&printstate.cond, &printstate.mutex, &future);
>  		if (time_has_passed(&future))
>  			break;
> -	};
> +	}
>  
>  	if (printstate_has_new_req_arrived(req))
>  		delay = -1;

Looks good but I would suggest to fix also the other instances of superfluous
semicolons with the same patch.

There seems to be a lonely semicolon on line 1944, i.e this code:

			if (value < 0) {
				warnx("TIME must be >= 0\n");
				show_usage();
				;
			}

In that case the lonely semicolon should be replaced with "exit(0);"

best regards,

Viktor