linux-kernel - RE: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210305002440epcms2p2205c56a96f6f8426fc1cb2d0cb7c16a3@epcms2p2>
Date:   Fri, 05 Mar 2021 09:24:40 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Bean Huo <huobean@...il.com>,
        Daejun Park <daejun7.park@...sung.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: RE: Re: [PATCH v26 4/4] scsi: ufs: Add HPB 2.0 support

Hi Bean,

> > +
> > +static inline void ufshpb_put_pre_req(struct ufshpb_lu *hpb,
> > +                                     struct ufshpb_req *pre_req)
> > +{
> > +       pre_req->req = NULL;
> > +       pre_req->bio = NULL;
> > +       list_add_tail(&pre_req->list_req, &hpb->lh_pre_req_free);
> > +       hpb->num_inflight_pre_req--;
> > +}
> > +
> > +static void ufshpb_pre_req_compl_fn(struct request *req,
> > blk_status_t error)
> > +{
> > +       struct ufshpb_req *pre_req = (struct ufshpb_req *)req-
> > >end_io_data;
> > +       struct ufshpb_lu *hpb = pre_req->hpb;
> > +       unsigned long flags;
> > +       struct scsi_sense_hdr sshdr;
> > +
> > +       if (error) {
> > +               dev_err(&hpb->sdev_ufs_lu->sdev_dev, "block status
> > %d", error);
> > +               scsi_normalize_sense(pre_req->sense,
> > SCSI_SENSE_BUFFERSIZE,
> > +                                    &sshdr);
> > +               dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> > +                       "code %x sense_key %x asc %x ascq %x",
> > +                       sshdr.response_code,
> > +                       sshdr.sense_key, sshdr.asc, sshdr.ascq);
> > +               dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> > +                       "byte4 %x byte5 %x byte6 %x additional_len
> > %x",
> > +                       sshdr.byte4, sshdr.byte5,
> > +                       sshdr.byte6, sshdr.additional_length);
> > +       }
>  
>  
> How can you print out sense_key and sense code here? sense code will
> not be copied to pre_req->sense. you should directly use
> scsi_request->sense or let pre_req->sense point to scsi_request->sense.

OK, I will fix it.

> You update the new version patch so quickly. In another word, I am
> wondering if you tested your patch before submitting?

I will check more carefully for the next patch.

Thanks,
Daejun