linux-kernel - Re: [PATCH] media: platform: xilinx: fix error return code of xvip_graph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5b346cb-5949-ec40-918b-59041d60929b@xilinx.com>
Date:   Fri, 5 Mar 2021 11:08:15 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>, <hyun.kwon@...inx.com>,
        <laurent.pinchart@...asonboard.com>, <mchehab@...nel.org>,
        <michal.simek@...inx.com>
CC:     <linux-media@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: platform: xilinx: fix error return code of
 xvip_graph_init()



On 3/5/21 10:48 AM, Jia-Ju Bai wrote:
> When the list of xdev->notifier.asd_list is empty, no error return code
> of xvip_graph_init() is assigned.
> To fix this bug, ret is assigned with -ENOENT as error return code.
> 
> Reported-by: TOTE Robot <oslab@...nghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
>  drivers/media/platform/xilinx/xilinx-vipp.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> index bf4015d852e3..2ce31d7ce1a6 100644
> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> @@ -525,6 +525,7 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
>  
>  	if (list_empty(&xdev->notifier.asd_list)) {
>  		dev_err(xdev->dev, "no subdev found in graph\n");
> +		ret = -ENOENT;
>  		goto done;
>  	}
>  
> 

Reviewed-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal