linux-kernel - Re: [PATCH 1/2] iwlwifi: fix DVM build regression in 5.12-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 6 Mar 2021 21:32:41 +0100
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     Hugh Dickins <hughd@...gle.com>
Cc:     Luca Coelho <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Mordechay Goodstein <mordechay.goodstein@...el.com>,
        Jiri Kosina <jikos@...nel.org>, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iwlwifi: fix DVM build regression in 5.12-rc

On Sat, Mar 6, 2021 at 9:27 PM Hugh Dickins <hughd@...gle.com> wrote:
>
> On Sat, 6 Mar 2021, Sedat Dilek wrote:
> > On Sat, Mar 6, 2021 at 8:48 PM Hugh Dickins <hughd@...gle.com> wrote:
> > >
> > > There is no iwl_so_trans_cfg if CONFIG_IWLDVM but not CONFIG_IWLMVM:
> > > move the CONFIG_IWLMVM guard up before the problematic SnJ workaround
> > > to fix the build breakage.
> > >
> > > Fixes: 930be4e76f26 ("iwlwifi: add support for SnJ with Jf devices")
> > > Signed-off-by: Hugh Dickins <hughd@...gle.com>
> >
> > See "iwlwifi: pcie: fix iwl_so_trans_cfg link error when CONFIG_IWLMVM
> > is disabled" in [1].
> >
> > - Sedat -
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=62541e266703549550e77fd46138422dbdc881f1
>
> Thanks for looking out that and the other one, Sedat: I swear I checked
> linux-next before sending, but my check seems to have been... defective.
>

No problem, Hugh.

Here, I have also an iwldwm device aka Intel(R) Centrino(R) Advanced-N
6230 AGN (REV=0xB0) and needed both patches.
The opmode commit fixed a call-trace.

It is always good to check wireless-drivers Git and/or linux-wireless ML.

- Sedat -