linux-kernel - Re: [block] 52f019d43c: ndctl.test-libndctl.fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f40b1f53c029788e20fe175618d8772e36d648c.camel@intel.com>
Date:   Sat, 6 Mar 2021 20:33:04 +0000
From:   "Williams, Dan J" <dan.j.williams@...el.com>
To:     "hch@....de" <hch@....de>
CC:     lkp <lkp@...el.com>, "hare@...e.de" <hare@...e.de>,
        "olkuroch@...co.com" <olkuroch@...co.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "lkp@...ts.01.org" <lkp@...ts.01.org>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "Sang, Oliver" <oliver.sang@...el.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [block]  52f019d43c: ndctl.test-libndctl.fail

On Fri, 2021-03-05 at 08:42 +0100, Christoph Hellwig wrote:
> Dan,
> 
> can you make any sense of thos report?
[..]
> > check_set_config_data: dimm: 0 read2 data miscompare: 0
> > check_set_config_data: dimm: 0x1 read2 data miscompare: 0
> > check_set_config_data: dimm: 0x100 read2 data miscompare: 0
> > check_set_config_data: dimm: 0x101 read2 data miscompare: 0
> > check_dax_autodetect: dax_ndns: 0x558a74d92f00 ndns: 0x558a74d92f00
> > check_dax_autodetect: dax_ndns: 0x558a74d91f40 ndns: 0x558a74d91f40
> > check_pfn_autodetect: pfn_ndns: 0x558a74d91f40 ndns: 0x558a74d91f40
> > check_pfn_autodetect: pfn_ndns: 0x558a74d8c5e0 ndns: 0x558a74d8c5e0
> > check_btt_autodetect: btt_ndns: 0x558a74d8c5e0 ndns: 0x558a74d8c5e0
> > check_btt_autodetect: btt_ndns: 0x558a74da1390 ndns: 0x558a74da1390
> > check_btt_autodetect: btt_ndns: 0x558a74d8c5e0 ndns: 0x558a74d8c5e0
> > check_btt_autodetect: btt_ndns: 0x558a74d91f40 ndns: 0x558a74d91f40
> > namespace7.0: failed to write /dev/pmem7
> > check_namespaces: namespace7.0 validate_bdev failed
> > ndctl-test1 failed: -6
> > libkmod: ERROR ../libkmod/libkmod-module.c:793 kmod_module_remove_module: could not remove 'nfit_test': Resource temporarily unavailable
> > test-libndctl: FAIL

Yes, it looks like my unit test checks for exactly the behavior you
changed. It was convenient to test that the device could be switched
back to rw via BLKROSET, but I don't require that. The new behaviour of
letting the disk->ro take precedence makes more sense to me, so I'll
update the test for the new behaviour.

I.e. I don't think regressing a unit test counts as a userspace
regression.