linux-kernel - Re: [PATCH] clk: Fix doc of clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210307143013.GE1463@shell.armlinux.org.uk>
Date:   Sun, 7 Mar 2021 14:30:13 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     od@...c.me, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: Fix doc of clk_get_parent

On Sun, Mar 07, 2021 at 02:29:07PM +0000, Paul Cercueil wrote:
> Hi,
> 
> Le dim. 7 mars 2021 à 14:27, Russell King - ARM Linux admin
> <linux@...linux.org.uk> a écrit :
> > On Sun, Mar 07, 2021 at 02:06:26PM +0000, Paul Cercueil wrote:
> > >  On error, or when the passed parameter is NULL, the return value is
> > > NULL
> > >  and not a PTR_ERR()-encoded value.
> > 
> > No, the documentation is accurate. The CCF is just an implementation
> > of the API, the file you are modifying is the definitive API
> > documentation.
> 
> Well, then the code has to be fixed, because right now it returns NULL on
> error, since the 2.6 days.

And you consider NULL to be an error? A NULL clock isn't defined to be
an error by the API.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!