linux-kernel - Re: [PATCH] clk: Fix doc of clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ZCWLPQ.PR2X1S4YNGGC1@crapouillou.net>
Date:   Sun, 07 Mar 2021 15:58:11 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     od@...c.me, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: Fix doc of clk_get_parent



Le dim. 7 mars 2021 à 14:30, Russell King - ARM Linux admin 
<linux@...linux.org.uk> a écrit :
> On Sun, Mar 07, 2021 at 02:29:07PM +0000, Paul Cercueil wrote:
>>  Hi,
>> 
>>  Le dim. 7 mars 2021 à 14:27, Russell King - ARM Linux admin
>>  <linux@...linux.org.uk> a écrit :
>>  > On Sun, Mar 07, 2021 at 02:06:26PM +0000, Paul Cercueil wrote:
>>  > >  On error, or when the passed parameter is NULL, the return 
>> value is
>>  > > NULL
>>  > >  and not a PTR_ERR()-encoded value.
>>  >
>>  > No, the documentation is accurate. The CCF is just an 
>> implementation
>>  > of the API, the file you are modifying is the definitive API
>>  > documentation.
>> 
>>  Well, then the code has to be fixed, because right now it returns 
>> NULL on
>>  error, since the 2.6 days.
> 
> And you consider NULL to be an error? A NULL clock isn't defined to be
> an error by the API.

Fair enough. Ignore my patch then.

Cheers,
-Paul