[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <L7WLPQ.OX36H4LIU83T3@crapouillou.net>
Date: Sun, 07 Mar 2021 15:54:57 +0000
From: Paul Cercueil <paul@...pouillou.net>
To: 'Wei Yongjun <weiyongjun1@...wei.com>
Cc: Kishon Vijay Abraham I <kishon@...com>,
Vinod Koul <vkoul@...nel.org>,
周琰杰 <zhouyanjie@...yeetech.com>,
漆鹏振 <aric.pzqi@...enic.com>,
linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()
Le ven. 5 mars 2021 à 3:49, 'Wei Yongjun <weiyongjun1@...wei.com> a
écrit :
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic
> PHY framework.")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
Acked-by: Paul Cercueil <paul@...pouillou.net>
Cheers,
-Paul
> ---
> drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c
> b/drivers/phy/ingenic/phy-ingenic-usb.c
> index ea127b177f46..28c28d816484 100644
> --- a/drivers/phy/ingenic/phy-ingenic-usb.c
> +++ b/drivers/phy/ingenic/phy-ingenic-usb.c
> @@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct
> platform_device *pdev)
> }
>
> priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);
> - if (IS_ERR(priv))
> - return PTR_ERR(priv);
> + if (IS_ERR(priv->phy))
> + return PTR_ERR(priv->phy);
>
> phy_set_drvdata(priv->phy, priv);
>
>
Powered by blists - more mailing lists