linux-kernel - Re: [PATCH] ASoC: codecs/jz4770: Remove superfluous error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <G4WLPQ.USQXU1D7YOL61@crapouillou.net>
Date:   Sun, 07 Mar 2021 15:53:04 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Tang Bin <tangbin@...s.chinamobile.com>
Cc:     broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Zhang Shengju <zhangshengju@...s.chinamobile.com>
Subject: Re: [PATCH] ASoC: codecs/jz4770: Remove superfluous error message



Le dim. 7 mars 2021 à 15:21, Tang Bin <tangbin@...s.chinamobile.com> a 
écrit :
> The function devm_platform_ioremap_resource has already contained
> error message if failed, so remove superfluous dev_err here.
> 
> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>

Looks good.

Acked-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  sound/soc/codecs/jz4770.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c
> index 298689a07..5a24471a5 100644
> --- a/sound/soc/codecs/jz4770.c
> +++ b/sound/soc/codecs/jz4770.c
> @@ -900,11 +900,8 @@ static int jz4770_codec_probe(struct 
> platform_device *pdev)
>  	codec->dev = dev;
> 
>  	codec->base = devm_platform_ioremap_resource(pdev, 0);
> -	if (IS_ERR(codec->base)) {
> -		ret = PTR_ERR(codec->base);
> -		dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);
> -		return ret;
> -	}
> +	if (IS_ERR(codec->base))
> +		return PTR_ERR(codec->base);
> 
>  	codec->regmap = devm_regmap_init(dev, NULL, codec,
>  					&jz4770_codec_regmap_config);
> --
> 2.20.1.windows.1
> 
> 
>