linux-kernel - Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpxmJW56EfaP8DgvyRDdmtCWLx4b0G0cS_Wi6Y_5=kxmPH6Cg@mail.gmail.com>
Date:   Mon, 8 Mar 2021 14:00:33 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Marek Vasut <marex@...x.de>,
        Roman Guskov <rguskov@...electronics.com>
Subject: Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

On Mon, Mar 8, 2021 at 12:45 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Sun, Mar 07, 2021 at 06:14:49PM +0200, Andy Shevchenko wrote:
> > On Sun, Mar 7, 2021 at 4:22 PM Bartosz Golaszewski
> > <bgolaszewski@...libre.com> wrote:
> > > On Fri, Mar 5, 2021 at 1:02 PM Andy Shevchenko
> > > <andriy.shevchenko@...ux.intel.com> wrote:
> > > >
> > > > On STM32MP1, the GPIO banks are subnodes of pin-controller@...02000,
> > > > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for
> > > > pin-controller@...02000 is in drivers/pinctrl/stm32/pinctrl-stm32.c
> > > > and iterates over all of its DT subnodes when registering each GPIO
> > > > bank gpiochip. Each gpiochip has:
> > > >
> > > >   - gpio_chip.parent = dev,
> > > >     where dev is the device node of the pin controller
> > > >   - gpio_chip.of_node = np,
> > > >     which is the OF node of the GPIO bank
> > > >
> > > > Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node),
> > > > i.e. pin-controller@...02000 != pin-controller@...02000/gpio@...0*000.
> > > >
> > > > The original code behaved correctly, as it extracted the "gpio-line-names"
> > > > from of_fwnode_handle(chip.of_node) = pin-controller@...02000/gpio@...0*000.
> > > >
> > > > To achieve the same behaviour, read property from the firmware node.
>
> ...
>
> > > Did you run the OF unit tests on this? The check for the parent dev
> > > was added after a bug was reported that was only triggered in unit
> > > tests.
> >
> > Parent is not used anymore. But I can run unittests next week (or if
> > you know that they are failing now, can you please show the failure?).
>
> For the record:
> [   40.587868] ### dt-test ### end of unittest - 190 passed, 0 failed
>
> If you have tests failed, we need more information about what line fails, etc.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

No it's fine, I just wanted to make sure. Patch applied, thanks!

Bartosz