linux-kernel - Re: [PATCH] ASoC: core: Don't set platform name when of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210309153455.GB4878@sirena.org.uk>
Date:   Tue, 9 Mar 2021 15:34:55 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Daniel Baluta <daniel.baluta@....nxp.com>
Cc:     alsa-devel@...a-project.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, linux-kernel@...r.kernel.org, linux-imx@....com,
        ranjani.sridharan@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, shengjiu.wang@....com,
        Daniel Baluta <daniel.baluta@....com>
Subject: Re: [PATCH] ASoC: core: Don't set platform name when of_node is set

On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote:
> From: Daniel Baluta <daniel.baluta@....com>
> 
> Platform may be specified by either name or OF node but not
> both.
> 
> For OF node platforms (e.g i.MX) we end up with both platform name
> and of_node set and sound card registration will fail with the error:
> 
>   asoc-simple-card sof-sound-wm8960: ASoC: Neither/both
>   platform name/of_node are set for sai1-wm8960-hifi

This doesn't actually say what the change does.

> -			dai_link->platforms->name = component->name;
> +
> +			if (!dai_link->platforms->of_node)
> +				dai_link->platforms->name = component->name;

Why would we prefer the node name over something explicitly configured?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)