linux-kernel - Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 9 Mar 2021 23:35:28 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sanket Goswami <Sanket.Goswami@....com>,
        jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sanket Goswami <Sanket.Goswami@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@....com>
Subject: Re: [PATCH] i2c: add i2c bus driver for amd navi gpu

Hi Sanket,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wsa/i2c/for-next]
[also build test WARNING on v5.12-rc2 next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sanket-Goswami/i2c-add-i2c-bus-driver-for-amd-navi-gpu/20210309-213535
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: arm-randconfig-r033-20210308 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 820f508b08d7c94b2dd7847e9710d2bc36d3dd45)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/f1d0b9c128d45f6d55f3d3f864db2e7ebf42adc5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sanket-Goswami/i2c-add-i2c-bus-driver-for-amd-navi-gpu/20210309-213535
        git checkout f1d0b9c128d45f6d55f3d3f864db2e7ebf42adc5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/i2c/busses/i2c-designware-master.c:899:5: warning: no previous prototype for function 'amd_i2c_adap_quirk' [-Wmissing-prototypes]
   int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
       ^
   drivers/i2c/busses/i2c-designware-master.c:899:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
   ^
   static 
   1 warning generated.


vim +/amd_i2c_adap_quirk +899 drivers/i2c/busses/i2c-designware-master.c

   898	
 > 899	int amd_i2c_adap_quirk(struct dw_i2c_dev *amdev)
   900	{
   901		struct i2c_adapter *amdap = &amdev->adapter;
   902		int ret;
   903	
   904		if (!(amdev->flags & AMD_NON_INTR_MODE))
   905			return -ENODEV;
   906	
   907		return i2c_add_numbered_adapter(amdap);
   908	
   909		return ret;
   910	}
   911	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (42872 bytes)