linux-kernel - Re: [PATCH] crypto: allwinner: sun8i-ce: fix error return code in sun8i_ce_prng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEcZSJ4T/Z0M4VaU@Red>
Date:   Tue, 9 Mar 2021 07:44:24 +0100
From:   Corentin Labbe <clabbe.montjoie@...il.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        mripard@...nel.org, wens@...e.org, jernej.skrabec@...l.net,
        mchehab+huawei@...nel.org, corbet@....net,
        linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: allwinner: sun8i-ce: fix error return code in
 sun8i_ce_prng_generate()

Le Thu, Mar 04, 2021 at 05:57:17PM -0800, Jia-Ju Bai a écrit :
> When dma_mapping_error() returns an error, no error return code of 
> sun8i_ce_prng_generate() is assigned.
> To fix this bug, err is assigned with -EFAULT as error return code.
> 
> Reported-by: TOTE Robot <oslab@...nghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
> ---
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c
> index cfde9ee4356b..cd1baee424a1 100644
> --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c
> +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-prng.c
> @@ -99,6 +99,7 @@ int sun8i_ce_prng_generate(struct crypto_rng *tfm, const u8 *src,
>  	dma_iv = dma_map_single(ce->dev, ctx->seed, ctx->slen, DMA_TO_DEVICE);
>  	if (dma_mapping_error(ce->dev, dma_iv)) {
>  		dev_err(ce->dev, "Cannot DMA MAP IV\n");
> +		err = -EFAULT;
>  		goto err_iv;
>  	}
>  
> -- 
> 2.17.1
> 

Hello

Tested-by: Corentin Labbe <clabbe.montjoie@...il.com>
Acked-by: Corentin Labbe <clabbe.montjoie@...il.com>

Thanks