lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <bcc2c2c9-5ad7-ba04-fe81-ca1728e81dc2@infradead.org>
Date:   Wed, 10 Mar 2021 09:19:44 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Xiaofeng Cao <cxfcosmos@...il.com>, mchehab@...nel.org,
        patrice.chotard@...com
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Correct 'so'

On 3/10/21 6:58 AM, Xiaofeng Cao wrote:
> In Kconfig it should be 'to'
> In c8sectpfe-core.c it should be 'do'
> 
> Signed-off-by: Xiaofeng Cao <cxfcosmos@...il.com>

The Subject: could use some work, but the patch contents look good.
Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  drivers/media/Kconfig                                 | 2 +-
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 6222b3ae220b..b07812657cee 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -134,7 +134,7 @@ config MEDIA_PLATFORM_SUPPORT
>  	  This is found on Embedded hardware (SoC), on V4L2 codecs and
>  	  on some GPU and newer CPU chipsets.
>  
> -	  Say Y when you want to be able so see such devices.
> +	  Say Y when you want to be able to see such devices.
>  
>  config MEDIA_TEST_SUPPORT
>  	bool
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index a7a6ea666740..338b205ae3a7 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -655,7 +655,7 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
>  
>  	/*
>  	 * TODO FIXME we should detect some error conditions here
> -	 * and ideally so something about them!
> +	 * and ideally do something about them!
>  	 */
>  
>  	return IRQ_HANDLED;
> 


-- 
~Randy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ