linux-kernel - Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKAP5Up7=qJEM6E0HuV2-faaVqTg+S=pdD8RpWyJ3KVcQ@mail.gmail.com>
Date:   Wed, 10 Mar 2021 10:19:44 -0700
From:   Rob Herring <robh@...nel.org>
To:     Nava kishore Manne <navam@...inx.com>
Cc:     "mdf@...nel.org" <mdf@...nel.org>,
        "trix@...hat.com" <trix@...hat.com>,
        Michal Simek <michals@...inx.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        Jolly Shah <JOLLYS@...inx.com>, Rajan Vaja <RAJANV@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        Manish Narani <MNARANI@...inx.com>,
        Amit Sunil Dhamne <amitsuni@...inx.com>,
        Tejas Patel <tejasp@...x.xilinx.com>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "chinnikishore369@...il.com" <chinnikishore369@...il.com>,
        Appana Durga Kedareswara Rao <appanad@...inx.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

On Wed, Mar 10, 2021 at 10:12 AM Rob Herring <robh@...nel.org> wrote:
>
> On Wed, Mar 10, 2021 at 3:50 AM Nava kishore Manne <navam@...inx.com> wrote:
> >
> > Hi Rob,
> >
> >         Thanks for providing the review comments.
> > Please find my response inline.
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@...nel.org>
> > > Sent: Tuesday, March 9, 2021 1:50 AM
> > > To: Nava kishore Manne <navam@...inx.com>
> > > Cc: mdf@...nel.org; trix@...hat.com; Michal Simek <michals@...inx.com>;
> > > gregkh@...uxfoundation.org; Jolly Shah <JOLLYS@...inx.com>; Rajan Vaja
> > > <RAJANV@...inx.com>; arnd@...db.de; Manish Narani
> > > <MNARANI@...inx.com>; Amit Sunil Dhamne <amitsuni@...inx.com>; Tejas
> > > Patel <tejasp@...x.xilinx.com>; linux-fpga@...r.kernel.org;
> > > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-arm-
> > > kernel@...ts.infradead.org; chinnikishore369@...il.com; Appana Durga
> > > Kedareswara Rao <appanad@...inx.com>
> > > Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> > > manager
> > >
> > > On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote:
> > > > From: Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>
> > > >
> > > > This patch adds binding doc for versal fpga manager driver.
> > >
> > > Why do you need a DT entry for this? Can't the Versal firmware driver
> > > instantiate the fpga-mgr device?
> > >
> > This dt entry is need to handle the fpga regions properly for both full and Partial bitstream loading use cases and it cannot be done by Versal firmware driver instantiate.
>
> Ah yes, I forgot about that.

Looking at this some more, please convert xlnx,zynqmp-firmware.txt to
schema and add the node for this there. We don't need a whole other
schema file just for a node and compatible. Also, looks like
xlnx,zynqmp-pcap-fpga.txt is the prior version of the same thing, so
it should be handled in the schema too.

Rob