linux-kernel - Re: [PATCH] docs: don't include Documentation/Kconfig twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc2a235f-01bd-e00b-5459-d903e03b3ed8@infradead.org>
Date:   Wed, 10 Mar 2021 10:33:29 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sergei Trofimovich <slyfox@...too.org>,
        linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Cc:     Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] docs: don't include Documentation/Kconfig twice

On 3/7/21 6:00 AM, Sergei Trofimovich wrote:
> Before the change there were two inclusions of Documentation/Kconfig:
>     lib/Kconfig.debug:source "Documentation/Kconfig"
>     Kconfig: source "Documentation/Kconfig"
> 
> Kconfig also included 'source "lib/Kconfig.debug"'.
> 
> Noticed as two 'make menuconfig' entries in both top level menu
> and in 'Kernel hacking' menu. The patch keeps entries only in
> 'Kernel hacking'.
> 
> CC: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> CC: Jonathan Corbet <corbet@....net>
> Signed-off-by: Sergei Trofimovich <slyfox@...too.org>

Hi,
OK, it shouldn't be there in 2 places.

The current usage is good under Kernel Hacking (development),
but I can easily foresee cases where we would want user-selectable
Documentation/Kconfig options, so IMO it would be better to be
more independent (i.e., not in lib/Kconfig.debug).

Anyway, for either way that it's fixed:

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>


> ---
>  Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Kconfig b/Kconfig
> index 745bc773f567..97ed6389c921 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -28,5 +28,3 @@ source "crypto/Kconfig"
>  source "lib/Kconfig"
>  
>  source "lib/Kconfig.debug"
> -
> -source "Documentation/Kconfig"
> 

thanks.
-- 
~Randy