linux-kernel - Re: [PATCH] docs: don't include Documentation/Kconfig twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87czw01952.fsf@meer.lwn.net>
Date:   Mon, 15 Mar 2021 13:58:49 -0600
From:   Jonathan Corbet <corbet@....net>
To:     Sergei Trofimovich <slyfox@...too.org>,
        linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Cc:     Sergei Trofimovich <slyfox@...too.org>
Subject: Re: [PATCH] docs: don't include Documentation/Kconfig twice

Sergei Trofimovich <slyfox@...too.org> writes:

> Before the change there were two inclusions of Documentation/Kconfig:
>     lib/Kconfig.debug:source "Documentation/Kconfig"
>     Kconfig: source "Documentation/Kconfig"
>
> Kconfig also included 'source "lib/Kconfig.debug"'.
>
> Noticed as two 'make menuconfig' entries in both top level menu
> and in 'Kernel hacking' menu. The patch keeps entries only in
> 'Kernel hacking'.
>
> CC: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
> CC: Jonathan Corbet <corbet@....net>
> Signed-off-by: Sergei Trofimovich <slyfox@...too.org>
> ---
>  Kconfig | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Kconfig b/Kconfig
> index 745bc773f567..97ed6389c921 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -28,5 +28,3 @@ source "crypto/Kconfig"
>  source "lib/Kconfig"
>  
>  source "lib/Kconfig.debug"
> -
> -source "Documentation/Kconfig"
> -- 
> 2.30.1

I agree with not including it twice.  Under "kernel hacking" seems like
the wrong place to keep it, though.  There's a lot more than kernel
hacking in the kernel docs, I don't think we should bury it in quite
that way.  So I'd delete the other one.

Thanks,

jon