linux-kernel - Re: [PATCH] greybus/operation: Drop reference when message has been set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEiSOB05c0iyOFFj@kroah.com>
Date:   Wed, 10 Mar 2021 10:32:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lv Yunlong <lyl2019@...l.ustc.edu.cn>
Cc:     johan@...nel.org, elder@...nel.org, greybus-dev@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] greybus/operation: Drop reference when message has been
 set

On Wed, Mar 10, 2021 at 01:10:14AM -0800, Lv Yunlong wrote:
> In gb_operation_response_send, get an extra reference
> before gb_message_send() with this comment "/* Reference will
> be dropped when message has been sent. */". Therefore, we
> should drop the got reference not only in the error branch,
> but also in the complete branch.

That's not what your patch does at all :(