linux-kernel - Re: Re: [PATCH] greybus/operation: Drop reference when message has been set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <180e2dc9.9f50.1781c7669f7.Coremail.lyl2019@mail.ustc.edu.cn>
Date:   Wed, 10 Mar 2021 22:07:05 +0800 (GMT+08:00)
From:   lyl2019@...l.ustc.edu.cn
To:     "Greg KH" <gregkh@...uxfoundation.org>
Cc:     johan@...nel.org, elder@...nel.org, greybus-dev@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] greybus/operation: Drop reference when message has
 been set

Sorry, i mistakenly divided the patch into two commits. What i have sent
is the latest commit which corrected my grammar in the patch.

I will send the full patch soon.


> -----原始邮件-----
> 发件人: "Greg KH" <gregkh@...uxfoundation.org>
> 发送时间: 2021-03-10 17:32:40 (星期三)
> 收件人: "Lv Yunlong" <lyl2019@...l.ustc.edu.cn>
> 抄送: johan@...nel.org, elder@...nel.org, greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
> 主题: Re: [PATCH] greybus/operation: Drop reference when message has been set
> 
> On Wed, Mar 10, 2021 at 01:10:14AM -0800, Lv Yunlong wrote:
> > In gb_operation_response_send, get an extra reference
> > before gb_message_send() with this comment "/* Reference will
> > be dropped when message has been sent. */". Therefore, we
> > should drop the got reference not only in the error branch,
> > but also in the complete branch.
> 
> That's not what your patch does at all :(
>