lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Mar 2021 08:24:50 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Ionela Voinescu <ionela.voinescu@....com> Cc: Rafael Wysocki <rjw@...ysocki.net>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Sudeep Holla <sudeep.holla@....com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, linux-pm@...r.kernel.org, Vincent Guittot <vincent.guittot@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V5 1/2] topology: Allow multiple entities to provide sched_freq_tick() callback On 09-03-21, 15:11, Ionela Voinescu wrote: > On Monday 01 Mar 2021 at 12:21:17 (+0530), Viresh Kumar wrote: > > diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h > > index 0f6cd6b73a61..3bcfba5c21a7 100644 > > --- a/include/linux/arch_topology.h > > +++ b/include/linux/arch_topology.h > > @@ -34,7 +34,19 @@ void topology_set_freq_scale(const struct cpumask *cpus, unsigned long cur_freq, > > unsigned long max_freq); > > bool topology_scale_freq_invariant(void); We don't normally add blank lines between declarations (variables or function), like what's done here. > > > > -bool arch_freq_counters_available(const struct cpumask *cpus); > > +enum scale_freq_source { > > + SCALE_FREQ_SOURCE_CPUFREQ = 0, > > + SCALE_FREQ_SOURCE_ARCH, > > +}; > > + > > +struct scale_freq_data { > > + enum scale_freq_source source; > > + void (*set_freq_scale)(void); > > +}; > > + > > +void topology_scale_freq_tick(void); > > +void topology_set_scale_freq_source(struct scale_freq_data *data, const struct cpumask *cpus); > > +void topology_clear_scale_freq_source(enum scale_freq_source source, const struct cpumask *cpus); > > Nit: can you split these lines? And so in order to be consistent across the file, I haven't added one here. -- viresh
Powered by blists - more mailing lists