linux-kernel - Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210311184033.GJ4962@sirena.org.uk>
Date:   Thu, 11 Mar 2021 18:40:33 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Andreas Kemnade <andreas@...nade.info>, j.neuschaefer@....net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

On Wed, Mar 10, 2021 at 09:48:21AM +0000, Lee Jones wrote:

> Could you take a look at this for me please:

> > +static int regmap_ignore_write(void *context,
> > +			       unsigned int reg, unsigned int val)
> > +
> > +{
> > +	struct regmap *regmap = context;
> > +
> > +	regmap_write(regmap, reg, val);
> > +
> > +	return 0;
> > +}

If there were more users it'd be better to have this in the core so that
problems we can detect like cache stuff if that's used but if it's just
one broken device it's probably not worth it, this seems like something
you'd have to try to end up with and which is going to cause timeout
problems with a lot of I2C controllers which would tank performance
enough that people would notice.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)