linux-kernel - Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YEyfTrTFzUaXiklf@latitude>
Date:   Sat, 13 Mar 2021 12:17:34 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Andreas Kemnade <andreas@...nade.info>, j.neuschaefer@....net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> On Mon, 08 Mar 2021, Andreas Kemnade wrote:
[...]
> > -static const struct mfd_cell ntxec_subdevices[] = {
> > +static const struct mfd_cell ntxec_subdev[] = {
> >  	{ .name = "ntxec-rtc" },
> >  	{ .name = "ntxec-pwm" },
> >  };
> >  
> > +static const struct mfd_cell ntxec_subdev_pwm[] = {
> > +	{ .name = "ntxec-pwm" },
> > +};
> 
> To put across what you're trying to achieve, maybe call this:
> 
>   ntxec_subdev_no_rtc[]
> 
> Then if other devices are added, the semantics/intent stays the same
> and it won't have to be renamed.

Andreas, what is the full amount of functionality this version of the EC
can ever provide?

If it's only PWM, I think ntxec_subdev_pwm fits well.

[ The next subdevice that I can foresee is battery monitoring. ]


Sorry for the delay,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)