linux-kernel - Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210313160757.084d74d0@aktux>
Date:   Sat, 13 Mar 2021 16:07:57 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

On Sat, 13 Mar 2021 12:17:34 +0100
Jonathan Neuschäfer <j.neuschaefer@....net> wrote:

> On Wed, Mar 10, 2021 at 09:55:45AM +0000, Lee Jones wrote:
> > On Mon, 08 Mar 2021, Andreas Kemnade wrote:  
> [...]
> > > -static const struct mfd_cell ntxec_subdevices[] = {
> > > +static const struct mfd_cell ntxec_subdev[] = {
> > >  	{ .name = "ntxec-rtc" },
> > >  	{ .name = "ntxec-pwm" },
> > >  };
> > >  
> > > +static const struct mfd_cell ntxec_subdev_pwm[] = {
> > > +	{ .name = "ntxec-pwm" },
> > > +};  
> > 
> > To put across what you're trying to achieve, maybe call this:
> > 
> >   ntxec_subdev_no_rtc[]
> > 
> > Then if other devices are added, the semantics/intent stays the same
> > and it won't have to be renamed.  
> 
> Andreas, what is the full amount of functionality this version of the EC
> can ever provide?
> 
> If it's only PWM, I think ntxec_subdev_pwm fits well.
> 
I think it is only PWM. At least I could not see any other I2C access.

> [ The next subdevice that I can foresee is battery monitoring. ]
> 
That is done via the RC5T619 on that device.

Regards,
Andreas