linux-kernel - Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 17:50:14 +0800
From:   Jianjun Wang <jianjun.wang@...iatek.com>
To:     Marc Zyngier <maz@...nel.org>,
        Pali Rohár <pali@...nel.org>
CC:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        <linux-pci@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        "Sj Huang" <sj.huang@...iatek.com>, <youlin.pei@...iatek.com>,
        <chuanjia.liu@...iatek.com>, <qizhong.cheng@...iatek.com>,
        <sin_jieyang@...iatek.com>, <drinkcat@...omium.org>,
        <Rex-BC.Chen@...iatek.com>, <anson.chuang@...iatek.com>
Subject: Re: [v8,5/7] PCI: mediatek-gen3: Add MSI support

On Thu, 2021-03-11 at 08:19 +0000, Marc Zyngier wrote:
> On 2021-03-11 00:05, Pali Rohár wrote:
> > On Wednesday 24 February 2021 14:11:30 Jianjun Wang wrote:
> >> +static int mtk_msi_bottom_domain_alloc(struct irq_domain *domain,
> >> +				       unsigned int virq, unsigned int nr_irqs,
> >> +				       void *arg)
> >> +{
> >> +	struct mtk_pcie_port *port = domain->host_data;
> >> +	struct mtk_msi_set *msi_set;
> >> +	int i, hwirq, set_idx;
> >> +
> >> +	mutex_lock(&port->lock);
> >> +
> >> +	hwirq = bitmap_find_free_region(port->msi_irq_in_use, 
> >> PCIE_MSI_IRQS_NUM,
> >> +					order_base_2(nr_irqs));
> >> +
> >> +	mutex_unlock(&port->lock);
> >> +
> >> +	if (hwirq < 0)
> >> +		return -ENOSPC;
> >> +
> >> +	set_idx = hwirq / PCIE_MSI_IRQS_PER_SET;
> >> +	msi_set = &port->msi_sets[set_idx];
> >> +
> >> +	for (i = 0; i < nr_irqs; i++)
> >> +		irq_domain_set_info(domain, virq + i, hwirq + i,
> >> +				    &mtk_msi_bottom_irq_chip, msi_set,
> >> +				    handle_edge_irq, NULL, NULL);
> >> +
> >> +	return 0;
> >> +}
> >> +
> >> +static void mtk_msi_bottom_domain_free(struct irq_domain *domain,
> >> +				       unsigned int virq, unsigned int nr_irqs)
> >> +{
> >> +	struct mtk_pcie_port *port = domain->host_data;
> >> +	struct irq_data *data = irq_domain_get_irq_data(domain, virq);
> >> +
> >> +	mutex_lock(&port->lock);
> >> +
> >> +	bitmap_clear(port->msi_irq_in_use, data->hwirq, nr_irqs);
> > 
> > Marc, should not be there bitmap_release_region() with order_base_2()?
> > 
> > bitmap_release_region(port->msi_irq_in_use, data->hwirq, 
> > order_base_2(nr_irqs));
> > 
> > Because mtk_msi_bottom_domain_alloc() is allocating
> > order_base_2(nr_irqs) interrupts, not only nr_irqs.
> 
> Indeed, good catch.

I will fix it in the next version, thanks for your review.

> 
> Thanks,
> 
>          M.