linux-kernel - Re: [PATCH] bootconfig: Update prototype of setup_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 18:50:21 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Cao jin <jojing64@...il.com>
Cc:     linux-kernel@...r.kernel.org, mhiramat@...nel.org,
        akpm@...ux-foundation.org, rostedt@...dmis.org,
        keescook@...omium.org, vbabka@...e.cz
Subject: Re: [PATCH] bootconfig: Update prototype of setup_boot_config()

On Thu, 11 Mar 2021 16:52:13 +0800
Cao jin <jojing64@...il.com> wrote:

> Parameter "cmdline" has no use, drop it.

OK, this looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you,

> 
> Signed-off-by: Cao jin <jojing64@...il.com>
> ---
>  init/main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/init/main.c b/init/main.c
> index c68d784376ca..621a11ed18fb 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -404,7 +404,7 @@ static int __init bootconfig_params(char *param, char *val,
>  	return 0;
>  }
>  
> -static void __init setup_boot_config(const char *cmdline)
> +static void __init setup_boot_config(void)
>  {
>  	static char tmp_cmdline[COMMAND_LINE_SIZE] __initdata;
>  	const char *msg;
> @@ -471,7 +471,7 @@ static void __init setup_boot_config(const char *cmdline)
>  
>  #else
>  
> -static void __init setup_boot_config(const char *cmdline)
> +static void __init setup_boot_config(void)
>  {
>  	/* Remove bootconfig data from initrd */
>  	get_boot_config_from_initrd(NULL, NULL);
> @@ -869,7 +869,7 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void)
>  	pr_notice("%s", linux_banner);
>  	early_security_init();
>  	setup_arch(&command_line);
> -	setup_boot_config(command_line);
> +	setup_boot_config();
>  	setup_command_line(command_line);
>  	setup_nr_cpu_ids();
>  	setup_per_cpu_areas();
> -- 
> 2.29.2
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>