linux-kernel - Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 13 Mar 2021 12:25:04 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     j.neuschaefer@....net, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mfd: ntxec: Support for EC in Tolino Shine 2 HD

On Sat, Mar 13, 2021 at 11:42:58AM +0100, Andreas Kemnade wrote:
> Add the version of the EC in the Tolino Shine 2 HD
> to the supported versions. It seems not to have an RTC
> and does not ack data written to it.
> The vendor kernel happily ignores write errors, using
> I2C via userspace i2c-set also shows the error.
> So add a quirk to ignore that error.
> 
> PWM can be successfully configured despite of that error.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
[...]
> +static const struct mfd_cell ntxec_subdev_no_rtc[] = {
> +	{ .name = "ntxec-pwm" },
> +};

I left a comment/question about 'no_rtc' vs. 'pwm' in the other thread.


> -	res = devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE, ntxec_subdevices,
> -				   ARRAY_SIZE(ntxec_subdevices), NULL, 0, NULL);
> +	res = devm_mfd_add_devices(ec->dev, PLATFORM_DEVID_NONE,
> +				   subdevs, n_subdevs,
> +				   NULL, 0, NULL);

The last two lines might as well be one, width-wise.


This version of the patch looks nice and short :)
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)