linux-kernel - Re: [PATCH 2/3] regulator: bd9571mwv: Fix regulator name printed on registration failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53cd571332cd7e941589a25c284fc9e28c69725f.camel@fi.rohmeurope.com>
Date:   Mon, 15 Mar 2021 07:49:32 +0200
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 2/3] regulator: bd9571mwv: Fix regulator name printed
 on registration failure


On Fri, 2021-03-12 at 14:02 +0100, Geert Uytterhoeven wrote:
> If a regulator fails to register, the driver prints an error message
> like:
> 
>     bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to
> register bd9571mwv-regulator regulator
> 
> However, the platform device's name is already printed as part of
> dev_err(), and does not allow the user to distinguish among the
> various
> regulators that are part of the PMIC.
> 
> Fix this by printing regulator_desc.name instead, to change the
> message
> like:
> 
>     bd9571mwv-regulator bd9571mwv-regulator.6.auto: failed to
> register DVFS regulator
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>