linux-kernel - RE: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only for "phy" or "link" sub-nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR07MB6160EAB28F3A60B2E7582672C56C9@MN2PR07MB6160.namprd07.prod.outlook.com>
Date:   Mon, 15 Mar 2021 05:50:04 +0000
From:   Swapnil Kashinath Jakhade <sjakhade@...ence.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Lokesh Vutla <lokeshvutla@...com>
Subject: RE: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only
 for "phy" or "link" sub-nodes



> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@...com>
> Sent: Wednesday, March 10, 2021 9:16 PM
> To: Kishon Vijay Abraham I <kishon@...com>; Vinod Koul
> <vkoul@...nel.org>; Rob Herring <robh+dt@...nel.org>; Philipp Zabel
> <p.zabel@...gutronix.de>; Swapnil Kashinath Jakhade
> <sjakhade@...ence.com>
> Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; Lokesh Vutla
> <lokeshvutla@...com>
> Subject: [PATCH v6 03/13] phy: cadence: cadence-sierra: Create PHY only for
> "phy" or "link" sub-nodes
> 

Nitpick, subject line in all Sierra patches in the series could be uniform.
Maybe, phy: cadence: Sierra as per earlier commits.

Reviewed-by: Swapnil Jakhade <sjakhade@...ence.com>

Thanks & regards,
Swapnil

> EXTERNAL MAIL
> 
> 
> Cadence Sierra PHY driver registers PHY using devm_phy_create()
> for all sub-nodes of Sierra device tree node. However Sierra device
> tree node can have sub-nodes for the various clocks in addtion to the
> PHY. Use devm_phy_create() only for nodes with name "phy" (or "link"
> for old device tree) which represent the actual PHY.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  drivers/phy/cadence/phy-cadence-sierra.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c
> b/drivers/phy/cadence/phy-cadence-sierra.c
> index 19f32ae877b9..f7ba0ed416bc 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -577,6 +577,10 @@ static int cdns_sierra_phy_probe(struct
> platform_device *pdev)
>  	for_each_available_child_of_node(dn, child) {
>  		struct phy *gphy;
> 
> +		if (!(of_node_name_eq(child, "phy") ||
> +		      of_node_name_eq(child, "link")))
> +			continue;
> +
>  		sp->phys[node].lnk_rst =
>  			of_reset_control_array_get_exclusive(child);
> 
> --
> 2.17.1