linux-kernel - RE: [PATCH v6 05/13] phy: cadence: cadence-sierra: Move all clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR07MB61602C0EB3273C0C51995994C56C9@MN2PR07MB6160.namprd07.prod.outlook.com>
Date:   Mon, 15 Mar 2021 05:50:52 +0000
From:   Swapnil Kashinath Jakhade <sjakhade@...ence.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Lokesh Vutla <lokeshvutla@...com>
Subject: RE: [PATCH v6 05/13] phy: cadence: cadence-sierra: Move all
 clk_get_*() to a separate function



> -----Original Message-----
> From: Kishon Vijay Abraham I <kishon@...com>
> Sent: Wednesday, March 10, 2021 9:16 PM
> To: Kishon Vijay Abraham I <kishon@...com>; Vinod Koul
> <vkoul@...nel.org>; Rob Herring <robh+dt@...nel.org>; Philipp Zabel
> <p.zabel@...gutronix.de>; Swapnil Kashinath Jakhade
> <sjakhade@...ence.com>
> Cc: linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; Lokesh Vutla
> <lokeshvutla@...com>
> Subject: [PATCH v6 05/13] phy: cadence: cadence-sierra: Move all clk_get_*()
> to a separate function
> 
> EXTERNAL MAIL
> 
> 
> No functional change. Group all devm_clk_get_optional() to a separate
> function.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
>  drivers/phy/cadence/phy-cadence-sierra.c | 57 +++++++++++++++---------
>  1 file changed, 35 insertions(+), 22 deletions(-)
> 

Reviewed-by: Swapnil Jakhade <sjakhade@...ence.com>

Thanks & regards,
Swapnil

> diff --git a/drivers/phy/cadence/phy-cadence-sierra.c
> b/drivers/phy/cadence/phy-cadence-sierra.c
> index f7ba0ed416bc..7bf1b4c7774a 100644
> --- a/drivers/phy/cadence/phy-cadence-sierra.c
> +++ b/drivers/phy/cadence/phy-cadence-sierra.c
> @@ -477,6 +477,38 @@ static int cdns_regmap_init_blocks(struct
> cdns_sierra_phy *sp,
>  	return 0;
>  }
> 
> +static int cdns_sierra_phy_get_clocks(struct cdns_sierra_phy *sp,
> +				      struct device *dev)
> +{
> +	struct clk *clk;
> +	int ret;
> +
> +	clk = devm_clk_get_optional(dev, "phy_clk");
> +	if (IS_ERR(clk)) {
> +		dev_err(dev, "failed to get clock phy_clk\n");
> +		return PTR_ERR(clk);
> +	}
> +	sp->clk = clk;
> +
> +	clk = devm_clk_get_optional(dev, "cmn_refclk_dig_div");
> +	if (IS_ERR(clk)) {
> +		dev_err(dev, "cmn_refclk_dig_div clock not found\n");
> +		ret = PTR_ERR(clk);
> +		return ret;
> +	}
> +	sp->cmn_refclk_dig_div = clk;
> +
> +	clk = devm_clk_get_optional(dev, "cmn_refclk1_dig_div");
> +	if (IS_ERR(clk)) {
> +		dev_err(dev, "cmn_refclk1_dig_div clock not found\n");
> +		ret = PTR_ERR(clk);
> +		return ret;
> +	}
> +	sp->cmn_refclk1_dig_div = clk;
> +
> +	return 0;
> +}
> +
>  static int cdns_sierra_phy_probe(struct platform_device *pdev)  {
>  	struct cdns_sierra_phy *sp;
> @@ -487,7 +519,6 @@ static int cdns_sierra_phy_probe(struct
> platform_device *pdev)
>  	unsigned int id_value;
>  	int i, ret, node = 0;
>  	void __iomem *base;
> -	struct clk *clk;
>  	struct device_node *dn = dev->of_node, *child;
> 
>  	if (of_get_child_count(dn) == 0)
> @@ -524,11 +555,9 @@ static int cdns_sierra_phy_probe(struct
> platform_device *pdev)
> 
>  	platform_set_drvdata(pdev, sp);
> 
> -	sp->clk = devm_clk_get_optional(dev, "phy_clk");
> -	if (IS_ERR(sp->clk)) {
> -		dev_err(dev, "failed to get clock phy_clk\n");
> -		return PTR_ERR(sp->clk);
> -	}
> +	ret = cdns_sierra_phy_get_clocks(sp, dev);
> +	if (ret)
> +		return ret;
> 
>  	sp->phy_rst = devm_reset_control_get(dev, "sierra_reset");
>  	if (IS_ERR(sp->phy_rst)) {
> @@ -542,22 +571,6 @@ static int cdns_sierra_phy_probe(struct
> platform_device *pdev)
>  		return PTR_ERR(sp->apb_rst);
>  	}
> 
> -	clk = devm_clk_get_optional(dev, "cmn_refclk_dig_div");
> -	if (IS_ERR(clk)) {
> -		dev_err(dev, "cmn_refclk_dig_div clock not found\n");
> -		ret = PTR_ERR(clk);
> -		return ret;
> -	}
> -	sp->cmn_refclk_dig_div = clk;
> -
> -	clk = devm_clk_get_optional(dev, "cmn_refclk1_dig_div");
> -	if (IS_ERR(clk)) {
> -		dev_err(dev, "cmn_refclk1_dig_div clock not found\n");
> -		ret = PTR_ERR(clk);
> -		return ret;
> -	}
> -	sp->cmn_refclk1_dig_div = clk;
> -
>  	ret = clk_prepare_enable(sp->clk);
>  	if (ret)
>  		return ret;
> --
> 2.17.1