linux-kernel - RE: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6bc83972093a4be4ad163069a437ec25@AcuMS.aculab.com>
Date:   Mon, 15 Mar 2021 15:31:27 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Bartosz Golaszewski' <brgl@...ev.pl>,
        Joel Becker <jlbec@...lplan.org>,
        Christoph Hellwig <hch@....de>, Shuah Khan <shuah@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Kent Gibson <warthog618@...il.com>,
        Jonathan Corbet <corbet@....net>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
CC:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: RE: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags

From: Bartosz Golaszewski
> Sent: 15 March 2021 09:14
> 
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> For better readability and maintenance: use the (1UL << bit) for flag
> definitions.

If the values ever get printed in hex the hex definitions are
actually more useful.

	David

...
> -#define CONFIGFS_ROOT		0x0001
> -#define CONFIGFS_DIR		0x0002
> -#define CONFIGFS_ITEM_ATTR	0x0004
> -#define CONFIGFS_ITEM_BIN_ATTR	0x0008
> -#define CONFIGFS_ITEM_LINK	0x0020
> -#define CONFIGFS_USET_DIR	0x0040
> -#define CONFIGFS_USET_DEFAULT	0x0080
> -#define CONFIGFS_USET_DROPPING	0x0100
> -#define CONFIGFS_USET_IN_MKDIR	0x0200
> -#define CONFIGFS_USET_CREATING	0x0400
> +#define CONFIGFS_ROOT			(1UL << 0)
> +#define CONFIGFS_DIR			(1UL << 1)
> +#define CONFIGFS_ITEM_ATTR		(1UL << 2)
> +#define CONFIGFS_ITEM_BIN_ATTR		(1UL << 3)
> +#define CONFIGFS_ITEM_LINK		(1UL << 5)
> +#define CONFIGFS_USET_DIR		(1UL << 6)
> +#define CONFIGFS_USET_DEFAULT		(1UL << 7)
> +#define CONFIGFS_USET_DROPPING		(1UL << 8)
> +#define CONFIGFS_USET_IN_MKDIR		(1UL << 9)
> +#define CONFIGFS_USET_CREATING		(1UL << 10)
>  #define CONFIGFS_NOT_PINNED	(CONFIGFS_ITEM_ATTR | CONFIGFS_ITEM_BIN_ATTR)
> 
>  extern struct mutex configfs_symlink_mutex;
> --
> 2.30.1

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)