linux-kernel - Re: [PATCH v3] dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Mar 2021 10:23:38 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: arm: Convert nuvoton,npcm750 binding to
 YAML

On Sat, Mar 13, 2021 at 06:53:20PM +0100, Jonathan Neuschäfer wrote:
> The general trend is to have devicetree bindings in YAML format, to
> allow automatic validation of bindings and devicetrees.
> 
> Convert the NPCM SoC family's binding to YAML before it accumulates more
> entries.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
> 
> If someone else wants to be listed as the maintainer, please let me
> know.
> 
> 
> v3:
> - In this version, I removed the nuvoton,npcm750-evb compatible string
>   again. I had previously introduced it to simplify the binding a little
>   bit, but Tomer Maimon suggested to keep /compatible of
>   nuvoton-npcm750-evb.dts as-is (i.e. only use "nuvoton,npcm750", no
>   board-specific string).
>   Because of this change, I am not including Rob Herring's R-b tag.

I think you should add nuvoton,npcm750-evb. Not so much for that board, 
but to ensure any additional boards get a board specific compatible.

> 
> v2:
> - https://lore.kernel.org/lkml/20210116010907.3475405-1-j.neuschaefer@gmx.net/
>   https://lore.kernel.org/lkml/20210303154622.3018839-1-j.neuschaefer@gmx.net/
> - Fix indentation to satisfy yamllint
> - Fix $schema line
> ---
>  .../devicetree/bindings/arm/npcm/npcm.txt     |  6 ------
>  .../devicetree/bindings/arm/npcm/npcm.yaml    | 20 +++++++++++++++++++
>  2 files changed, 20 insertions(+), 6 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.txt
>  create mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/npcm/npcm.txt b/Documentation/devicetree/bindings/arm/npcm/npcm.txt
> deleted file mode 100644
> index 2d87d9ecea85b..0000000000000
> --- a/Documentation/devicetree/bindings/arm/npcm/npcm.txt
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -NPCM Platforms Device Tree Bindings
> ------------------------------------
> -NPCM750 SoC
> -Required root node properties:
> -	- compatible = "nuvoton,npcm750";
> -
> diff --git a/Documentation/devicetree/bindings/arm/npcm/npcm.yaml b/Documentation/devicetree/bindings/arm/npcm/npcm.yaml
> new file mode 100644
> index 0000000000000..8cca0396a5d59
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/npcm/npcm.yaml
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/npcm/npcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NPCM Platforms Device Tree Bindings
> +
> +maintainers:
> +  - Jonathan Neuschäfer <j.neuschaefer@....net>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: NPCM750 development board
> +        const: nuvoton,npcm750
> +
> +additionalProperties: true
> --
> 2.30.1
>