linux-kernel - Re: [PATCH v3] dt-bindings: arm: Convert nuvoton,npcm750 binding to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YE+dmdBBk0BZ7BIO@latitude>
Date:   Mon, 15 Mar 2021 18:47:05 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Rob Herring <robh@...nel.org>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
        Avi Fishman <avifishman70@...il.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Tali Perry <tali.perry1@...il.com>,
        Patrick Venture <venture@...gle.com>,
        Nancy Yuen <yuenn@...gle.com>,
        Benjamin Fair <benjaminfair@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: arm: Convert nuvoton,npcm750 binding to
 YAML

On Mon, Mar 15, 2021 at 10:23:38AM -0600, Rob Herring wrote:
> On Sat, Mar 13, 2021 at 06:53:20PM +0100, Jonathan Neuschäfer wrote:
> > The general trend is to have devicetree bindings in YAML format, to
> > allow automatic validation of bindings and devicetrees.
> > 
> > Convert the NPCM SoC family's binding to YAML before it accumulates more
> > entries.
> > 
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> > ---
> > 
> > If someone else wants to be listed as the maintainer, please let me
> > know.
> > 
> > 
> > v3:
> > - In this version, I removed the nuvoton,npcm750-evb compatible string
> >   again. I had previously introduced it to simplify the binding a little
> >   bit, but Tomer Maimon suggested to keep /compatible of
> >   nuvoton-npcm750-evb.dts as-is (i.e. only use "nuvoton,npcm750", no
> >   board-specific string).
> >   Because of this change, I am not including Rob Herring's R-b tag.
> 
> I think you should add nuvoton,npcm750-evb. Not so much for that board, 
> but to ensure any additional boards get a board specific compatible.

I'm inclined to agree and go back to v2, but I'd like to hear Tomer
Maimon's opinion first.

> > v2:
> > - https://lore.kernel.org/lkml/20210116010907.3475405-1-j.neuschaefer@gmx.net/
> >   https://lore.kernel.org/lkml/20210303154622.3018839-1-j.neuschaefer@gmx.net/
> > - Fix indentation to satisfy yamllint
> > - Fix $schema line


Thanks,
Jonathan Neuschäfer

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)