linux-kernel - Re: [PATCH v2 4/4] KVM: x86/mmu: Store the address space ID in the TDP iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YE/eXP60IVki7csd@google.com>
Date:   Mon, 15 Mar 2021 15:23:24 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Ben Gardon <bgardon@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Peter Shier <pshier@...gle.com>,
        Jim Mattson <jmattson@...gle.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 4/4] KVM: x86/mmu: Store the address space ID in the
 TDP iterator

On Mon, Mar 15, 2021, Ben Gardon wrote:

Missing "From: Sean Christopherson <seanjc@...gle.com>", i.e. the commit in your
local tree needs "git commit --amend --author="Sean Christopherson <seanjc@...gle.com>".
Alternatively, you could just erase my SOB ;-)

> Store the address space ID in the TDP iterator so that it can be
> retrieved without having to bounce through the root shadow page.  This
> streamlines the code and fixes a Sparse warning about not properly using
> rcu_dereference() when grabbing the ID from the root on the fly.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Ben Gardon <bgardon@...gle.com>
> ---