linux-kernel - Re: [PATCH 3/7] ASoC: codecs: wcd938x: add basic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e112ca1-f618-6a6c-fc1e-854de3c8acfe@linaro.org>
Date:   Mon, 15 Mar 2021 10:04:56 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     perex@...ex.cz, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, lgirdwood@...il.com
Subject: Re: [PATCH 3/7] ASoC: codecs: wcd938x: add basic driver



On 12/03/2021 15:34, Mark Brown wrote:
> On Thu, Mar 11, 2021 at 05:34:12PM +0000, Srinivas Kandagatla wrote:
> 
>> +static int wcd9380_update_status(struct sdw_slave *slave,
>> +				 enum sdw_slave_status status)
>> +{
>> +	return 0;
>> +}
>> +
>> +static int wcd9380_port_prep(struct sdw_slave *slave,
>> +			     struct sdw_prepare_ch *prepare_ch,
>> +			     enum sdw_port_prep_ops state)
>> +{
>> +	return 0;
>> +}
> 
> If these can legitimately be empty I'd expect the framework to support
> them being omitted.

One of them is not mandatory, I will revisit this before sending out 
next version.

thanks,
srini
>