linux-kernel - Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YE9YGGB+k7CsCNDI@smile.fi.intel.com>
Date:   Mon, 15 Mar 2021 14:50:32 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Marek Vasut <marex@...x.de>,
        Roman Guskov <rguskov@...electronics.com>
Subject: Re: [PATCH v1 1/1] gpiolib: Read "gpio-line-names" from a firmware
 node

On Mon, Mar 15, 2021 at 12:16:26PM +0200, Andy Shevchenko wrote:
> On Mon, Mar 15, 2021 at 10:01:47AM +0100, Bartosz Golaszewski wrote:
> > On Fri, Mar 5, 2021 at 1:03 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > Unfortunately while this may fix the particular use-case on STM32, it
> > breaks all other users as the 'gpio-line-names' property doesn't live
> > on dev_fwnode(&gdev->dev) but on dev_fwnode(chip->parent).
> > 
> > How about we first look for this property on the latter and only if
> > it's not present descend down to the former fwnode?
> 
> Oops, I have tested on x86 and it worked the same way.
> 
> Lemme check this, but I think the issue rather in ordering when we apply fwnode
> to the newly created device and when we actually retrieve gpio-line-names
> property.

Hmm... I can't see how it's possible can be. Can you provide a platform name
and pointers to the DTS that has been broken by the change?


-- 
With Best Regards,
Andy Shevchenko