linux-kernel - Re: [PATCH v4] rtc: rx6110: add ACPI bindings to I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFDjDhsCikxtl5rw@smile.fi.intel.com>
Date:   Tue, 16 Mar 2021 18:55:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Claudius Heine <ch@...x.de>
Cc:     johannes hahn <johannes-hahn@...mens.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        werner zeh <werner.zeh@...mens.com>,
        henning schild <henning.schild@...mens.com>,
        martin mantel <martin.mantel@...mens.com>,
        val krutov <val.krutov@....epson.com>
Subject: Re: [PATCH v4] rtc: rx6110: add ACPI bindings to I2C

On Tue, Mar 16, 2021 at 03:48:18PM +0100, Claudius Heine wrote:
> From: Johannes Hahn <johannes-hahn@...mens.com>
> 
> This allows the RX6110 driver to be automatically assigned to the right
> device on the I2C bus.

You missed given tag, when somebody sends you one, it's usually your
responsibility to pick it up. Hint: install b4 tool (likely in your distro, at
least Debian, Arch Linux have it) and run it against message ID of the version
in question. It will gather all tags. For example, for this case, run

  % b4 am 20210316144819.4130622-1-ch@...x.de

It will download mailbox suitable for `git am ...` you will read on the screen.

Also, when send a new version, don't attach it to the old thread. It will
confuse people and maybe even tools (i.o.w. don't supply message ID to be put
to In-Reply-To header).

So, repeat again my tag and see one fix to be performed below.
Reviewed-by: From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Johannes Hahn <johannes-hahn@...mens.com>
> Co-developed-by: Claudius Heine <ch@...x.de>
> Signed-off-by: Claudius Heine <ch@...x.de>
> ---
>  drivers/rtc/rtc-rx6110.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
> index 79161d4c6ce4..2a06953c0a84 100644
> --- a/drivers/rtc/rtc-rx6110.c
> +++ b/drivers/rtc/rtc-rx6110.c
> @@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
>  	return rx6110_probe(rx6110, &client->dev);
>  }
>  
> +static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
> +	{ "SECC6110" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
> +
>  static const struct i2c_device_id rx6110_i2c_id[] = {
>  	{ "rx6110", 0 },
>  	{ }
> @@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
>  static struct i2c_driver rx6110_i2c_driver = {
>  	.driver = {
>  		.name = RX6110_DRIVER_NAME,
> +		.acpi_match_table = ACPI_PTR(rx6110_i2c_acpi_match),

Since you drop ifdeffery above, you have to drop ACPI_PTR() (besides that
ACPI_PTR() requires acpi.h to be included).

>  	},
>  	.probe		= rx6110_i2c_probe,
>  	.id_table	= rx6110_i2c_id,
> -- 
> 2.30.1
> 

-- 
With Best Regards,
Andy Shevchenko