linux-kernel - Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6afe1c65-d50d-4bd7-2ad3-93d9b067afc5@roeck-us.net>
Date:   Mon, 15 Mar 2021 20:35:31 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "jdelvare@...e.com" <jdelvare@...e.com>
Cc:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

On 3/15/21 8:30 PM, Chris Packham wrote:
> 
> On 16/03/21 3:35 pm, Chris Packham wrote:
>> The BPA-RS600 is a compact 600W AC to DC removable power supply module.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>>
>> +static const struct of_device_id __maybe_unused bpa_rs600_of_match[] = {
>> +	{ .compatible = "blutek,bpa-rs600" },
>> +	{},
>> +};
> 
> I see this will fall foul of the name check in 
> __hwmon_device_register(). How should I name things to avoid this?
> 

It isn't the binding. The driver name should not have a '-' in it.
You could just name it bpa_rs600 instead.

Guenter