[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3458b6e9-db88-db10-0b1b-ae8e776fb830@alliedtelesis.co.nz>
Date: Tue, 16 Mar 2021 03:41:38 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Guenter Roeck <linux@...ck-us.net>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"jdelvare@...e.com" <jdelvare@...e.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600
On 16/03/21 4:35 pm, Guenter Roeck wrote:
> On 3/15/21 8:30 PM, Chris Packham wrote:
>> On 16/03/21 3:35 pm, Chris Packham wrote:
>>> The BPA-RS600 is a compact 600W AC to DC removable power supply module.
>>>
>>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>>>
>>> +static const struct of_device_id __maybe_unused bpa_rs600_of_match[] = {
>>> + { .compatible = "blutek,bpa-rs600" },
>>> + {},
>>> +};
>> I see this will fall foul of the name check in
>> __hwmon_device_register(). How should I name things to avoid this?
>>
> It isn't the binding. The driver name should not have a '-' in it.
> You could just name it bpa_rs600 instead.
Sold.
I'll give the world a chance to turn so people can look at the rest of
the patch before I send a v2.
Powered by blists - more mailing lists