linux-kernel - Re: [PATCH] smp: kernel/panic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e1a9910-a266-f327-2f5e-413b2f60546a@infradead.org>
Date:   Mon, 15 Mar 2021 22:15:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     He Ying <heying24@...wei.com>, peterz@...radead.org,
        mingo@...nel.org, frederic@...nel.org, paulmck@...nel.org,
        christophe.leroy@...roup.eu, clg@...d.org, qais.yousef@....com
Cc:     johnny.chenyi@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] smp: kernel/panic.c - silence warnings

On 3/15/21 9:08 PM, He Ying wrote:
> We found these warnings in kernel/panic.c by using sparse tool:
> warning: symbol 'panic_smp_self_stop' was not declared.
> warning: symbol 'nmi_panic_self_stop' was not declared.
> warning: symbol 'crash_smp_send_stop' was not declared.
> 
> To avoid them, add declarations for these three functions in
> include/linux/smp.h.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: He Ying <heying24@...wei.com>
> ---
>  include/linux/smp.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index 70c6f6284dcf..861a253cc179 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -50,6 +50,14 @@ extern unsigned int total_cpus;
>  int smp_call_function_single(int cpuid, smp_call_func_t func, void *info,
>  			     int wait);
>  
> +/*
> + * Cpus stopping functions in panic. All have default weak definations.

                                                              definitions.

> + * Architecure dependent code may override them.

      Architecture-dependent


> + */
> +void panic_smp_self_stop(void);
> +void nmi_panic_self_stop(struct pt_regs *regs);
> +void crash_smp_send_stop(void);
> +
>  /*
>   * Call a function on all processors
>   */
> 


-- 
~Randy