linux-kernel - Re: [PATCH] smp: kernel/panic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f18e835b-12a5-bd59-fa40-f6893deea59d@huawei.com>
Date:   Tue, 16 Mar 2021 14:35:57 +0800
From:   "heying (H)" <heying24@...wei.com>
To:     Randy Dunlap <rdunlap@...radead.org>, <peterz@...radead.org>,
        <mingo@...nel.org>, <frederic@...nel.org>, <paulmck@...nel.org>,
        <christophe.leroy@...roup.eu>, <clg@...d.org>,
        <qais.yousef@....com>
CC:     <johnny.chenyi@...wei.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] smp: kernel/panic.c - silence warnings

Thanks for your reply.


在 2021/3/16 13:15, Randy Dunlap 写道:
> On 3/15/21 9:08 PM, He Ying wrote:
>> We found these warnings in kernel/panic.c by using sparse tool:
>> warning: symbol 'panic_smp_self_stop' was not declared.
>> warning: symbol 'nmi_panic_self_stop' was not declared.
>> warning: symbol 'crash_smp_send_stop' was not declared.
>>
>> To avoid them, add declarations for these three functions in
>> include/linux/smp.h.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: He Ying <heying24@...wei.com>
>> ---
>>   include/linux/smp.h | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/include/linux/smp.h b/include/linux/smp.h
>> index 70c6f6284dcf..861a253cc179 100644
>> --- a/include/linux/smp.h
>> +++ b/include/linux/smp.h
>> @@ -50,6 +50,14 @@ extern unsigned int total_cpus;
>>   int smp_call_function_single(int cpuid, smp_call_func_t func, void *info,
>>   			     int wait);
>>   
>> +/*
>> + * Cpus stopping functions in panic. All have default weak definations.
>                                                                definitions.
Sorry for my typo.
>
>> + * Architecure dependent code may override them.
>        Architecture-dependent
Is that necessary?
>
>
>> + */
>> +void panic_smp_self_stop(void);
>> +void nmi_panic_self_stop(struct pt_regs *regs);
>> +void crash_smp_send_stop(void);
>> +
>>   /*
>>    * Call a function on all processors
>>    */
>>
>