linux-kernel - Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YFCW3Kx9MPm0MT8H@smile.fi.intel.com>
Date:   Tue, 16 Mar 2021 13:30:36 +0200
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Claudius Heine <ch@...x.de>
Cc:     johannes hahn <johannes-hahn@...mens.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        werner zeh <werner.zeh@...mens.com>,
        henning schild <henning.schild@...mens.com>,
        martin mantel <martin.mantel@...mens.com>,
        val krutov <val.krutov@....epson.com>
Subject: Re: [PATCH v3 1/1] rtc: rx6110: add ACPI bindings to I2C

On Tue, Mar 16, 2021 at 11:08:05AM +0100, Claudius Heine wrote:
> From: Johannes Hahn <johannes-hahn@...mens.com>
> 
> This allows the RX6110 driver to be automatically assigned to the right
> device on the I2C bus.

Thanks for all effort!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
after addressing the below comments.

> Signed-off-by: Johannes Hahn <johannes-hahn@...mens.com>
> Signed-off-by: Claudius Heine <ch@...x.de>

> Signed-off-by: Henning Schild <henning.schild@...mens.com>

I think this is somehow confusing. Either you need to add Co-developed-by of
the corresponding people, or remove SoB (because of From line), i.o.w seems
like Co-dB tag is needed for Johannes or you and something should be done with
Henning's SoB.

> ---
>  drivers/rtc/rtc-rx6110.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c
> index 79161d4c6ce4..29bd697f82cb 100644
> --- a/drivers/rtc/rtc-rx6110.c
> +++ b/drivers/rtc/rtc-rx6110.c
> @@ -13,6 +13,7 @@
>  #include <linux/of_gpio.h>
>  #include <linux/regmap.h>
>  #include <linux/rtc.h>

> +#include <linux/acpi.h>

Usually it's not needed if you leave IDs always to be compiled.
Instead mod_devicetable.h is used. But it's all up to you and maintainer.

>  #include <linux/of.h>
>  #include <linux/of_device.h>
>  #include <linux/spi/spi.h>
> @@ -447,6 +448,14 @@ static int rx6110_i2c_probe(struct i2c_client *client,
>  	return rx6110_probe(rx6110, &client->dev);
>  }
>  
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
> +	{ "SECC6110", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
> +#endif
> +
>  static const struct i2c_device_id rx6110_i2c_id[] = {
>  	{ "rx6110", 0 },
>  	{ }
> @@ -456,6 +465,9 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
>  static struct i2c_driver rx6110_i2c_driver = {
>  	.driver = {
>  		.name = RX6110_DRIVER_NAME,
> +#ifdef CONFIG_ACPI

This is implied by the stub ACPI_PTR() macro for ACPI=n case.
I.o.w drop this ugly and redundant ifdeffery.

> +		.acpi_match_table = ACPI_PTR(rx6110_i2c_acpi_match),
> +#endif
>  	},
>  	.probe		= rx6110_i2c_probe,
>  	.id_table	= rx6110_i2c_id,
> -- 
> 2.30.1
> 

-- 
With Best Regards,
Andy Shevchenko